content: Add support for keyword highlighting in code blocks #1707
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
But only allowing a single element for now, making the diff for content tests simpler for the later commit which implements support for multiple span types. Also better formatting for code block HTML in content tests.
The code block spans with `hll` (and `highlight` used for search keyword highlighting) classes can be nested inside other types of code block spans. So add support for parsing those types of spans. The rendered text style will be result of merging all the corresponding `TextStyle` using `TextStyle.merge`, preserving the order of those nested spans.
rajveermalviya
force-pushed
the
pr-codeblock-highlight
branch
from
c79bf5b to
2c8fe02
Compare
|
Changed the base from #1694 to |
rajveermalviya
added
the
integration review
|
Sent #1737 as the tree based version of this implementation, and it turns out to be much faster than this PR. Flat list (this PR)Tree (#1737) |
|
OK — thanks for making those measurements! That's a big effect, so glad we did. Specifically that looks like around 15ms parsing, and 130ms rendering, each of which is longer than a frame (which can be as short as ~8ms). And the other version is about 2ms total, much shorter. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #1695
Screenshots when commits based on top of #1694: